Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement update script #102 #137

Merged
merged 6 commits into from
Mar 22, 2024
Merged

feat: implement update script #102 #137

merged 6 commits into from
Mar 22, 2024

Conversation

ayildirim21
Copy link
Member

@ayildirim21 ayildirim21 commented Mar 19, 2024 •
edited
Loading

Improve the CI of SDK as per #1363

@ayildirim21 ayildirim21 marked this pull request as draft March 19, 2024 07:00
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (df6afe6) to head (a9968de).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          46       46           
  Lines        1513     1513           
  Branches       83       83           
=======================================
  Hits         1441     1441           
  Misses         51       51           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayildirim21 ayildirim21 marked this pull request as ready for review March 19, 2024 17:25
@ayildirim21 ayildirim21 changed the title feat: implement update script and build/push workflow #102 feat: implement update script #102 Mar 20, 2024
KeranYang
KeranYang reviewed Mar 22, 2024
View reviewed changes
.hack/update_examples.sh Outdated Show resolved Hide resolved
examples/developer_guide/README.md Outdated Show resolved Hide resolved
examples/developer_guide/README.md Outdated Show resolved Hide resolved
@KeranYang KeranYang merged commit c3f9c60 into numaproj:main Mar 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeranYang KeranYang KeranYang approved these changes

@ab93 ab93 Awaiting requested review from ab93 ab93 is a code owner

@vigith vigith Awaiting requested review from vigith vigith is a code owner

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayildirim21 @KeranYang