Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new reduce proto #133

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Mar 5, 2024

Fixes #1545

  1. Add support for new proto specifications
  2. Refactor reducer to include task manager

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.12230% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.24%. Comparing base (882302b) to head (5bfd9ea).

Files Patch % Lines
pynumaflow/reducer/servicer/async_servicer.py 92.00% 0 Missing and 2 partials ⚠️
pynumaflow/reducer/servicer/task_manager.py 96.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   95.21%   95.24%   +0.02%     
==========================================
  Files          45       46       +1     
  Lines        1442     1513      +71     
  Branches       81       83       +2     
==========================================
+ Hits         1373     1441      +68     
- Misses         50       51       +1     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid changed the title feate: add support for new reduce proto feat: add support for new reduce proto Mar 5, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid marked this pull request as ready for review March 6, 2024 03:34
@vigith vigith requested a review from yhl25 March 6, 2024 04:03
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid merged commit df6afe6 into numaproj:main Mar 6, 2024
10 checks passed
@kohlisid kohlisid deleted the reduce-proto branch March 6, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update existing reduce Python sdk to make it compatible with the new proto.
2 participants