Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) graceful shutdown - yhl's version #152

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

KeranYang
Copy link
Member

No description provided.

Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 16.45570% with 66 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@134414a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../io/numaproj/numaflow/sinker/GrpcServerHelper.java 2.56% 38 Missing ⚠️
.../main/java/io/numaproj/numaflow/sinker/Server.java 27.77% 24 Missing and 2 partials ⚠️
...main/java/io/numaproj/numaflow/sinker/Service.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage        ?   58.90%           
  Complexity      ?      393           
=======================================
  Files           ?      127           
  Lines           ?     2842           
  Branches        ?      197           
=======================================
  Hits            ?     1674           
  Misses          ?     1031           
  Partials        ?      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant