Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify MapStream and Unary Map Operations Using a Shared gRPC Protocol #146

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Oct 13, 2024

No description provided.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a5cdc00). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...java/io/numaproj/numaflow/mapstreamer/Service.java 74.50% 12 Missing and 1 partial ⚠️
...ava/io/numaproj/numaflow/sinker/SinkerTestKit.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage        ?   60.53%           
  Complexity      ?      392           
=======================================
  Files           ?      126           
  Lines           ?     2762           
  Branches        ?      189           
=======================================
  Hits            ?     1672           
  Misses          ?      955           
  Partials        ?      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhl25 yhl25 marked this pull request as ready for review October 14, 2024 09:52
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 merged commit 707c5bf into main Oct 14, 2024
5 checks passed
@yhl25 yhl25 deleted the bidi-mapstream branch October 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants