From cf96b6011f7c01a3346eae8bea3dca7c834271e0 Mon Sep 17 00:00:00 2001
From: Yashash H L <yashashhl25@gmail.com>
Date: Tue, 8 Oct 2024 14:08:40 +0530
Subject: [PATCH] review comments

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
---
 src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java | 2 ++
 src/test/java/io/numaproj/numaflow/mapper/ServerTest.java    | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java b/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java
index b8fe977..637100a 100644
--- a/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java
+++ b/src/test/java/io/numaproj/numaflow/mapper/ServerErrTest.java
@@ -22,6 +22,7 @@
 import java.util.List;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
 
 public class ServerErrTest {
 
@@ -125,6 +126,7 @@ public void testMapperFailure() {
 
         try {
             responseObserver.done.get();
+            fail("Expected exception not thrown");
         } catch (Exception e) {
             assertEquals(
                     "io.grpc.StatusRuntimeException: UNKNOWN: unknown exception",
diff --git a/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java b/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java
index 0069f78..553a8b6 100644
--- a/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java
+++ b/src/test/java/io/numaproj/numaflow/mapper/ServerTest.java
@@ -133,6 +133,7 @@ public void testMapperWithoutHandshake() {
 
         try {
             responseObserver.done.get();
+            fail("Expected an exception to be thrown");
         } catch (InterruptedException | ExecutionException e) {
             assertEquals(
                     "io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Handshake request not received",