diff --git a/.github/workflows/build-push.yaml b/.github/workflows/build-push.yaml index d0c6997..edf3bc4 100644 --- a/.github/workflows/build-push.yaml +++ b/.github/workflows/build-push.yaml @@ -8,8 +8,7 @@ on: jobs: docker_publish: - # run it only on numaproj/numaflow-java repository - # forked repositories normally don't have the proper permission setup. + # run workflow only on numaproj/numaflow-java repository if: ${{ github.repository }} == "numaproj/numaflow-java" name: Build, Tag, and Push Image runs-on: ubuntu-latest diff --git a/development.md b/development.md index 8eda450..2610148 100644 --- a/development.md +++ b/development.md @@ -47,5 +47,4 @@ If you add a new example, there are a few steps to follow in order for it to be 1. Add the example to the `examples/pom.xml`, within an execution element. Note that the `id` tag you specify must be exactly the same as the quay.io repository name for the example -2. Add the `id` tag you specified in step 1 to the `executionIDs` array in `hack/update_examples.sh` -3. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml` +2. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml` diff --git a/hack/update_examples.sh b/hack/update_examples.sh index 542ec0f..2696c8d 100755 --- a/hack/update_examples.sh +++ b/hack/update_examples.sh @@ -4,7 +4,7 @@ function show_help () { echo "Usage: $0 [-h|--help | -t|--tag ] (-bpe|--build-push-example )" echo " -h, --help Display help message and exit" echo " -bpe, --build-push-example Build the given example id (found in examples/pom.xml), and push it to the quay.io registry" - echo " -t, --tag To be optionally used with -bpe or -bp. Specify the tag to build with. Default tag: stable" + echo " -t, --tag To be optionally used with -bpe. Specify the tag to build with. Default tag: stable" } if [ $# -eq 0 ]; then @@ -79,12 +79,6 @@ if [ -n "$tag" ] && (( ! usingHelp )); then echo "Using tag: $tag" fi -executionIDs=("mapt-event-time-filter-function" "flat-map-stream" "map-flatmap" \ - "even-odd" "simple-sink" "reduce-sum" "reduce-stream-sum" \ - "map-forward-message" "reduce-counter" "sideinput-example" \ - "udf-sideinput-example" "source-simple-source" "session-reduce-count" - ) - function dockerPublish () { echo "Docker publish for example: $1" if ! docker tag numaflow-java-examples/"$1":"$tag" quay.io/numaio/numaflow-java/"$1":"$tag"; then