Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of memoize for average block time #37

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Remove use of memoize for average block time #37

merged 3 commits into from
Jul 30, 2024

Conversation

derekpierre
Copy link
Member

No description provided.

@derekpierre
Update use of deprecated function.
09ca18a
@derekpierre
Stop using memoize for average block time; atxm instance will now kee…
46e4af3 
…p a cached value of the determined busy interval that uses average block time.
@derekpierre derekpierre changed the title [WIP] Remove use of memoize for average block time Remove use of memoize for average block time Jul 29, 2024
@derekpierre derekpierre self-assigned this Jul 29, 2024
@derekpierre derekpierre marked this pull request as ready for review July 29, 2024 15:09
manumonti
manumonti approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But why are we removing memoize? Just trying to get the context.

@derekpierre
Copy link
Member Author

derekpierre commented Jul 30, 2024 •
edited
Loading

LGTM.

But why are we removing memoize? Just trying to get the context.

It's possible that memoize may be causing issues for Web3 instances - we've had issues with Web3 instances and caching before. Of course, we are still uncertain whether this matters or not, but applying this measure keeps the same functionality but removes this as a factor/uncertainty 😅 .

@KPrasch KPrasch merged commit 8e951c4 into nucypher:main Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manumonti manumonti manumonti approved these changes

@KPrasch KPrasch KPrasch approved these changes

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees

@derekpierre derekpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekpierre @KPrasch @manumonti