Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize Connect trait access #422

Merged

Conversation

jamescarterbell
Copy link
Contributor

Somewhere after ntex 0.4, the Connect was renamed and made internal, however I'm not seeing an issue with making it public for some testing scenarios.

ntex/src/http/client/response.rs Outdated Show resolved Hide resolved
ntex/src/http/client/connect.rs Show resolved Hide resolved
@fafhrd91 fafhrd91 merged commit 16bc0d6 into ntex-rs:master Sep 18, 2024
9 of 10 checks passed
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.07%. Comparing base (69f150e) to head (c128e9a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ntex/src/http/client/builder.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   91.16%   91.07%   -0.10%     
==========================================
  Files         200      200              
  Lines       32124    32127       +3     
==========================================
- Hits        29286    29259      -27     
- Misses       2838     2868      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants