Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for empty feed-titles and empty item-titles #463

Merged
merged 3 commits into from
Oct 15, 2023
Merged

fix for empty feed-titles and empty item-titles #463

merged 3 commits into from
Oct 15, 2023

Conversation

dym-sh
Copy link
Contributor

@dym-sh dym-sh commented Oct 15, 2023

fix for popup example url: https://thenib.tumblr.com/

popup

fix for reader example url: https://bitbang.social/@NanoRaptor.rss

reader

nt1m
nt1m approved these changes Oct 15, 2023
View reviewed changes
Copy link
Owner

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I was hoping the URL interface would provide an utility to strip the protocol, but looks like it doesn't, looks good for now.

Might need some fixes for eslint that I can do.

@nt1m nt1m merged commit 754df18 into nt1m:master Oct 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dym-sh @nt1m