Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orange icon in standard dark theme #420

Open
mare1203 opened this issue Aug 9, 2022 · 4 comments
Open

orange icon in standard dark theme #420

mare1203 opened this issue Aug 9, 2022 · 4 comments
Labels
firefox bug Needs to be fixed at the Firefox level

Comments

@mare1203
Copy link

mare1203 commented Aug 9, 2022

Add-on version
Add-on version: 3.5

Describe the bug
I would like to be able to set the orange color of the icon in the firefox dark theme as well

screenshot_1

@nt1m
Copy link
Owner

nt1m commented Nov 3, 2023

This actually seems like a Firefox bug, not a bug from this extension. Firefox seems to force a filter on extension icons in dark mode. https://searchfox.org/mozilla-central/rev/99a9eed20cf195b8ff815604876b6fb73ca5ecd7/browser/themes/shared/urlbar-searchbar.css#360-380

@RobWu @emilio Can we remove this? This extension has a setting to configure the extension icon color, and it's not getting honored.

@nt1m nt1m added the firefox bug Needs to be fixed at the Firefox level label Nov 3, 2023
@nt1m
Copy link
Owner

nt1m commented Nov 3, 2023

I meant to ping @Rob--W here :)

@emilio
Copy link

emilio commented Nov 3, 2023

Yeah, +1 on removing this, but it's at least blocked on a container extension release so mozilla/multi-account-containers#2584 and so is picked up...

@Rob--W
Copy link

Rob--W commented Nov 3, 2023

Emilio, do we need to block on that update? If an extension has explicitly declared a separate dark theme icon, then I would expect that icon to be used in unmodified form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firefox bug Needs to be fixed at the Firefox level
Projects
None yet
Development

No branches or pull requests

4 participants