You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use the git forking workflow and each developer open PRs against the upstream repo from their fork.
It seems from the code of nrwl/nx-set-shas@v4 that the main branch of the fork is used to compute the Base SHA, not the main branch of upstream. The code seems to systematically use origin/${mainBranchName}. In the context of a PR opened from a fork that target the upstream repo, origin refers to the remote of the fork.
Is there a way with the current implementation to have the Base SHA calculated using the actual target remote (e.g. upstream)?
If not, one solution would be to allow the user of the action to specify the remote too, in a similar way the action actions/checkout@v4 allows us to do so.
The text was updated successfully, but these errors were encountered:
Hi there @tschaffter ! I am looking into a way to implement this feature, but I am not sure how soon this will happen! If in the meantime you want to try implementing it, let me know and I can help!
We use the git forking workflow and each developer open PRs against the upstream repo from their fork.
It seems from the code of
nrwl/nx-set-shas@v4
that the main branch of the fork is used to compute the Base SHA, not the main branch of upstream. The code seems to systematically useorigin/${mainBranchName}
. In the context of a PR opened from a fork that target the upstream repo,origin
refers to the remote of the fork.Is there a way with the current implementation to have the Base SHA calculated using the actual target remote (e.g.
upstream
)?If not, one solution would be to allow the user of the action to specify the remote too, in a similar way the action
actions/checkout@v4
allows us to do so.The text was updated successfully, but these errors were encountered: