From 606d0ffbf2b08b3ef2858be98d7e1d1126d4f6bb Mon Sep 17 00:00:00 2001 From: Tommi Rantanen Date: Fri, 4 Oct 2024 15:49:00 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tommi Kangas --- .../releases/release-notes-changelog.rst | 2 +- include/modem/modem_info.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst index b2cd648143b..4b406220037 100644 --- a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst +++ b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst @@ -761,7 +761,7 @@ Modem libraries The formulas are now aligned with the modem implementation that has not changed but the AT command reference guide has not been up to date with the modem implementation. - * Removed ``RSRP_OFFSET_VAL`` and ``RSRQ_OFFSET_VAL`` from the API. + * Removed ``RSRP_OFFSET_VAL``, ``RSRQ_OFFSET_VAL`` and ``RSRQ_SCALE_VAL`` from the API. Clients should have used the :c:macro:`RSRP_IDX_TO_DBM` and the :c:macro:`RSRQ_IDX_TO_DB` macros. * :ref:`nrf_modem_lib_lte_net_if` library: diff --git a/include/modem/modem_info.h b/include/modem/modem_info.h index ec82be4b5e9..b3177d89cb9 100644 --- a/include/modem/modem_info.h +++ b/include/modem/modem_info.h @@ -51,9 +51,9 @@ extern "C" { /** @brief Converts RSRP index value returned by the modem to dBm. * * The index value of RSRP can be converted to decibel with the following formula: - * * Index < 0: Index – 140 - * * Index = 0: Not used - * * Index > 0: Index – 141 + * * index < 0: index – 140 + * * index = 0: Not used + * * index > 0: index – 141 * * Example values: * * -17: RSRP < -156 dBm @@ -79,10 +79,10 @@ extern "C" { /** @brief Converts RSRQ index value returned by the modem to dB. * * The index value of RSRQ can be converted to decibel with the following formula: - * * Index < 0: (Index – 39) / 2 - * * Index = 0: Not used - * * Index > 0 and index < 35: (Index – 40) / 2 - * * Index ≥ 35: (Index – 41) / 2 + * * index < 0: (index – 39) / 2 + * * index = 0: Not used + * * index > 0 and index < 35: (index – 40) / 2 + * * index ≥ 35: (index – 41) / 2 * * Example values: * * -30: RSRQ < -34.5 dB