Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Enforce DNS-1123 resource name compliance on ingest #26

Open
Mierdin opened this issue Nov 6, 2018 · 0 comments
Open

Enforce DNS-1123 resource name compliance on ingest #26

Mierdin opened this issue Nov 6, 2018 · 0 comments
Labels
complexity: low enhancement New feature or request

Comments

@Mierdin
Copy link
Member

Mierdin commented Nov 6, 2018

Endpoint names currently have no validation on ingest that forces compliance with kubernetes standards. See below error when trying to create an endpoint name with capital letters.

time="2018-11-06T07:41:26Z" level=error msg="Problem creating pod StackStorm: Pod \"StackStorm\" is invalid: [metadata.name: Invalid value: \"StackStorm\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), spec.containers[0].name: Invalid value: \"StackStorm\": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')]"

Validation should be added to all relevant fields in db types that will result in a kubernetes resource name that conforms to this spec.

@Mierdin Mierdin added the enhancement New feature or request label Nov 21, 2019
@Mierdin Mierdin changed the title force lower case on resource creation. Enforce DNS-1123 resource name compliance on ingest May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
complexity: low enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant