Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dots in the schema name causes ArgumentException while creating a collation #2451

Closed
eymentopcuoglu opened this issue Jul 27, 2022 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eymentopcuoglu
Copy link

Hi!

We would like to speed up our case-insensitive queries using collations. We are using HasCollation() in OnModelCreating(). But the problem is that our schema names include dots, which causes ArgumentException:

// Yes, this doesn't support dots in the schema/collation name, let somebody complain first.

Is using a different separator in your plans?

Thanks in advance!

@roji roji added the bug Something isn't working label Jul 27, 2022
@roji roji self-assigned this Jul 27, 2022
@roji roji added this to the 7.0.0 milestone Jul 27, 2022
@roji
Copy link
Member

roji commented Jul 27, 2022

I'll try to take a look at this for 7.0.

@eymentopcuoglu
Copy link
Author

Thank you! I would love to help if I can!

@roji
Copy link
Member

roji commented Oct 18, 2022

Duplicate of #2495

@roji roji marked this as a duplicate of #2495 Oct 18, 2022
@roji
Copy link
Member

roji commented Oct 18, 2022

I looked into this, and the right way to fix this is to redo the annotations as per #2495. I did some work in this direction, but was unfortunately blocked by the lack of value tuple support in EF Core's C# literal code generation (dotnet/efcore#29383).

It may be possible to hack around with another solution, but given that time is very short and it's easy to work around this with SQL in the migration, I'm punting it for 8.0 - but will do this quite soon there.

@roji roji closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants