chore(dashboard): revert trigger success toast #6987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX and
desiprisg
LetItRock
commented
Nov 13, 2024
| actionLabel="View activity feed" | ||
| onAction={() => { | ||
| close(); | ||
| navigate(buildRoute(LEGACY_ROUTES.ACTIVITY_FEED, { transactionId })); |
There was a problem hiding this comment.
The navigate here works like an internal routing, there is no option to do a full page reload on navigate, which is something we want because we navigate to a different "app" served by "legacy" folder.
BiswaViraj
approved these changes
Nov 13, 2024
LetItRock
force-pushed
the
revert-trigger-toast
branch
from
28e8034
to
8a95011
Compare
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Reverted the changes we did for the success trigger workflow toast, because navigate doesn't support full page reload.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer