feat(node): add deleteByTransactionId method #6980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jainpawan21
commented
Nov 13, 2024
| * | ||
| * @param {string} transactionId - The unique identifier of the event whose notifications will be deleted. | ||
| */ | ||
| async deleteByTransactionId(transactionId: string) { |
There was a problem hiding this comment.
Shall I rename this method to deleteMessagesBytTransactionId to highlight that all messages related to this transactionId will be deleted?
There was a problem hiding this comment.
No, it's already on the messaged domain. So I think it's totally fine
scopsy
approved these changes
Nov 13, 2024
jainpawan21
deleted the
feature/add-delete-messages-by-transaction-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
deleteByTransactionIdmethodScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer