Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-GO-1] API 🚀: Validate MX Record Setup for Inbound Parse Functionality #8

Open
unicodeveloper opened this issue Mar 20, 2023 · 3 comments · Fixed by #29
Open
Assignees

Comments

@unicodeveloper
Copy link
Contributor

🔖 Feature description

There should be a service that validates MX Record Setup for Inbound Parse Functionality

🎤 API Reference
https://docs.novu.co/api/validate-the-mx-record-setup-for-the-inbound-parse-functionality/

@unicodeveloper unicodeveloper changed the title [NV-GO] API 🚀: Validate MX Record Setup for Inbound Parse Functionality [NV-GO-1] API 🚀: Validate MX Record Setup for Inbound Parse Functionality Mar 20, 2023
@codeliter
Copy link

Hey @unicodeveloper ,

I just want to say, great job, everyone!!

I would like to contribute, but I have a question.

The NewAPIClient constructor piqued my curiosity. I noticed that when a new client is initialized all services available are injected into the client:

go-novu/lib/novu.go

Lines 53 to 56 in 9fc2a94

c.EventApi = (*EventService)(&c.common)
c.SubscriberApi = (*SubscriberService)(&c.common)
c.TopicsApi = (*TopicService)(&c.common)
c.IntegrationsApi = (*IntegrationService)(&c.common)

I would appreciate it if I can get more context as to why this pattern was chosen. A doc or a reply here will be nice.

@NonsoAmadi10
Copy link
Contributor

Hi @unicodeveloper I would like to pick this issue. For context, I noticed every api reference on the documentation have their own file and folder, for the inbound parse functionality, I am thinking i need to create that file as well and write the test, is this correct or there is a file already for this?

@NonsoAmadi10
Copy link
Contributor

We can close this issue then @unicodeveloper ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants