Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single RuntimeIdentifier (without RuntimeIdentifiers): folder layout changed #229

Open
xen2 opened this issue May 27, 2020 · 0 comments
Open

Comments

@xen2
Copy link
Contributor

xen2 commented May 27, 2020

With such a project file:

<Project Sdk="MSBuild.Sdk.Extras/2.0.85">
  <PropertyGroup>
    <TargetFrameworks>netstandard2.0</TargetFrameworks>
    <RuntimeIdentifier>win7-x64</RuntimeIdentifier>
  </PropertyGroup>
</Project>

Note that there are no RuntimeIdentifiers (there is only a single runtime)

Behavior of previous versions of MSBuild.Sdk.Extras (2.0.54)
nupkg contains a lib/netstandard2.0 folder (it only built a runtimes/ folder if RuntimeIdentifiers was set)

Behavior of new versions of MSBuild.Sdk.Extras (2.0.85)
nupkg contains a runtimes/win7-x64/lib/netstandard2.0 folder

I was wondering if new behavior was intentional or if it's a regression.
If regression, I can submit a PR to revert to the old behavior.
If not, I would like to submit a PR to make it configurable through a MSBuild variable.

@xen2 xen2 changed the title Setting RuntimeIdentifier without RuntimeIdentifiers: runtimes/ folder in new version Setting RuntimeIdentifier without RuntimeIdentifiers: folder layout changed May 27, 2020
@xen2 xen2 changed the title Setting RuntimeIdentifier without RuntimeIdentifiers: folder layout changed RuntimeIdentifier without RuntimeIdentifiers: folder layout changed May 27, 2020
@xen2 xen2 changed the title RuntimeIdentifier without RuntimeIdentifiers: folder layout changed Single RuntimeIdentifier (without RuntimeIdentifiers): folder layout changed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant