NovelRT::Ecs::TransformComponent: scale inheritance in the scene hierarchy is arithmetic instead of geometric

[dndn1011]

Hi,

I was taking a look at the engine and noticed that scales are combined by addition, instead of multiplication.

positionAndLayer += other.positionAndLayer; rotationInRadians += other.rotationInRadians; scale += other.scale;

Usually, scale is a multiplier, is this by intention?

-Dino

[capnkenny]

Hi Dino!

I'll let @RubyNova confirm or correct me since it is his domain area, however I do believe this is intentional.
TransformComponent.scale is treated as a multiplier insofar as it is multiplied to the generated scaleValue for scaling the matrix of the object being manipulated, and can be added to / removed from to adjust the scaling of said object. For more detail, you can look here as a reference to how the current DefaultRenderingSystem currently handles it.

-Kenny