Rpc crawler #18
Rpc crawler #18
Conversation
WalkthroughThe recent updates introduce enhanced thread safety in Go codebases through synchronization mechanisms in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (3)
- .github/workflows/test.yml (1 hunks)
- lib/checknode.go (3 hunks)
- lib/lib.go (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/test.yml
Additional comments not posted (10)
lib/checknode.go (8)
15-15: Added mutex forearliestBlockto ensure thread safety.
17-17: Added mutex forrpcAddrto ensure thread safety.
19-19: Added mutex forgrpcAddrto ensure thread safety.
21-21: Added mutex forapiAddrto ensure thread safety.
23-23: Added mutex formonikerto ensure thread safety.
29-29: Added mutex forarchiveNodesto ensure thread safety.
33-38: Ensure proper locking and unlocking aroundrpcAddrmap access to prevent data races.
49-72: Ensure thread safety by locking and unlocking around map reinitializations. This is crucial when resetting the state in a concurrent environment.lib/lib.go (2)
91-106: UpdatedFetchNodeInfoGRPCto use a context with a timeout, improving the management of network resources and handling potential long-running operations more gracefully.
110-112: UpdatedFetchNetInfoto use a context with a timeout, enhancing the reliability of network operations by managing long-running requests effectively.
| if client == nil { | ||
| color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| return | ||
| } | ||
|
|
||
| ctx := context.TODO() | ||
| status, err := client.Status(ctx) | ||
| if err != nil { | ||
| color.Red("[%s] cannot fetch status\n", time.Now().Format("2006-01-02 15:04:05")) | ||
| return | ||
| } | ||
| if status == nil { | ||
| color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| return |
There was a problem hiding this comment.
Proper error handling and user feedback when client operations fail. However, consider using a more structured logging approach instead of direct user feedback for better maintainability.
- color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr)
+ log.Errorf("Client is nil for %s at %s", nodeAddr, time.Now().Format("2006-01-02 15:04:05"))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if client == nil { | |
| color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| } | |
| ctx := context.TODO() | |
| status, err := client.Status(ctx) | |
| if err != nil { | |
| color.Red("[%s] cannot fetch status\n", time.Now().Format("2006-01-02 15:04:05")) | |
| return | |
| } | |
| if status == nil { | |
| color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| if client == nil { | |
| log.Errorf("Client is nil for %s at %s", nodeAddr, time.Now().Format("2006-01-02 15:04:05")) | |
| return | |
| } | |
| ctx := context.TODO() | |
| status, err := client.Status(ctx) | |
| if err != nil { | |
| color.Red("[%s] cannot fetch status\n", time.Now().Format("2006-01-02 15:04:05")) | |
| return | |
| } | |
| if status == nil { | |
| color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return |
| if client == nil { | ||
| color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| return | ||
| } | ||
| netinfo, err := FetchNetInfo(client) | ||
| if err == nil { | ||
| color.Green("[%s] Got net info from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| CheckNodeGRPC(nodeAddr) | ||
| // CheckNodeGRPC(nodeAddr) | ||
| ctx := context.TODO() | ||
| status, err := client.Status(ctx) | ||
| moniker[nodeAddr] = status.NodeInfo.Moniker | ||
| if err != nil { | ||
| color.Red("[%s] Failed to fetch client from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| return | ||
| } | ||
| if status == nil { | ||
| color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | ||
| return |
There was a problem hiding this comment.
Ensure proper error handling and user feedback when client operations fail. Similar to previous comment, consider using structured logging.
- color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr)
+ log.Errorf("Status is nil for %s at %s", nodeAddr, time.Now().Format("2006-01-02 15:04:05"))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if client == nil { | |
| color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| } | |
| netinfo, err := FetchNetInfo(client) | |
| if err == nil { | |
| color.Green("[%s] Got net info from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| CheckNodeGRPC(nodeAddr) | |
| // CheckNodeGRPC(nodeAddr) | |
| ctx := context.TODO() | |
| status, err := client.Status(ctx) | |
| moniker[nodeAddr] = status.NodeInfo.Moniker | |
| if err != nil { | |
| color.Red("[%s] Failed to fetch client from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| } | |
| if status == nil { | |
| color.Red("[%s] Status is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| if client == nil { | |
| color.Red("[%s] Client is nil for %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| } | |
| netinfo, err := FetchNetInfo(client) | |
| if err == nil { | |
| color.Green("[%s] Got net info from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| // CheckNodeGRPC(nodeAddr) | |
| ctx := context.TODO() | |
| status, err := client.Status(ctx) | |
| if err != nil { | |
| color.Red("[%s] Failed to fetch client from %s\n", time.Now().Format("2006-01-02 15:04:05"), nodeAddr) | |
| return | |
| } | |
| if status == nil { | |
| log.Errorf("Status is nil for %s at %s", nodeAddr, time.Now().Format("2006-01-02 15:04:05")) | |
| return |
Check for problems by actually running the crawler
Summary by CodeRabbit
FetchNodeInfoGRPCfunction to returnnilon success.