Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly specify crossbeam-channel as feature. #622

Conversation

waywardmonkeys
Copy link
Contributor

The feature controlling the usage of crossbeam_channel is not crossbeam.

This has been incorrect since it was made optional in be6ef8a.

The feature controlling the usage of `crossbeam_channel` is
not `crossbeam`.

This has been incorrect since it was made optional in be6ef8a.
@waywardmonkeys
Copy link
Contributor Author

This is a fix for the upcoming issue of the unexpected_cfgs lint getting enabled in Rust 1.80

@0xpr03
Copy link
Member

0xpr03 commented Jul 20, 2024

Can be closed since crossbeam channel will go away.
#525

@dfaust
Copy link
Member

dfaust commented Aug 10, 2024

@0xpr03: I removed the internal use of crossbeam-channel, but it can still be used as a notification handler.

I also noticed this issue and fixed it in PR #630. I saw this PR only now.

@dfaust dfaust closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants