Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency check fails if depencency is installed to /usr/sbin #5

Open
csnover opened this issue May 27, 2024 · 1 comment
Open

Dependency check fails if depencency is installed to /usr/sbin #5

csnover opened this issue May 27, 2024 · 1 comment

Comments

@csnover
Copy link

csnover commented May 27, 2024

Looking for nvme dependency that is installed to /usr/sbin using which does not work since PATH does not include that directory for regular users on at least Debian. Instead, just try running the command, and then report an error if it fails with a hint that the dependency is maybe missing (or, do like the shell script did and just have users escalate privileges themselves).

@not-a-feature
Copy link
Owner

Having directly escalated privileges instead of using those only for the required commands is a bad practice.

But just running the command could be a option. The which approach was used as it was primarily developed for Linux Mint / Ubuntu where this works fine.

@not-a-feature not-a-feature changed the title Dependency check is broken Dependency check fails if depencency is installed to /usr/sbin May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants