From 268674127fa1ca01ac561963db45c10cb4e07f95 Mon Sep 17 00:00:00 2001 From: Aaron Sherrill Date: Tue, 9 Oct 2018 11:00:00 -0400 Subject: [PATCH 1/5] Added myself as a contributor --- package.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package.json b/package.json index 07e16e8..8f90784 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,10 @@ { "name": "Karel Piwko", "url": "https://github.com/kpiwko" + }, + { + "name": "Aaron Sherrill", + "url": "https://github.com/motionharvest" } ], "scripts": { From ba23fd063fe050989161e7d2317a284cbdd3096c Mon Sep 17 00:00:00 2001 From: Aaron Sherrill Date: Tue, 9 Oct 2018 11:00:38 -0400 Subject: [PATCH 2/5] Added trailing slash to /boards/ call --- main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.js b/main.js index 9b07098..079451a 100644 --- a/main.js +++ b/main.js @@ -92,7 +92,7 @@ Trello.prototype.addBoard = function (name, description, organizationId, callbac if (organizationId !== null) query.idOrganization = organizationId; - return makeRequest(rest.post, this.uri + '/1/boards', {query: query}, callback); + return makeRequest(rest.post, this.uri + '/1/boards/', {query: query}, callback); }; Trello.prototype.updateBoardPref = function (boardId, field, value, callback) { From 558032770c26ec875c20d7003044b8759f3be082 Mon Sep 17 00:00:00 2001 From: Aaron Sherrill Date: Tue, 9 Oct 2018 11:01:39 -0400 Subject: [PATCH 3/5] updated tests with trailing slash --- test/spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/spec.js b/test/spec.js index c25e916..4023876 100644 --- a/test/spec.js +++ b/test/spec.js @@ -119,8 +119,8 @@ describe('Trello', function () { }); }); - it('should post to https://api.trello.com/1/boards', function () { - post.should.have.been.calledWith('https://api.trello.com/1/boards'); + it('should post to https://api.trello.com/1/boards/', function () { + post.should.have.been.calledWith('https://api.trello.com/1/boards/'); }); it('should include the description', function () { From 81decd7ffc438b54759ce56062c820dde0c9acd0 Mon Sep 17 00:00:00 2001 From: Aaron Sherrill Date: Tue, 9 Oct 2018 11:08:15 -0400 Subject: [PATCH 4/5] Small tweak to indentation of contributors, and ignoring package-lock --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 654189c..3af397d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ node_modules .vscode/launch.json +package-lock.json From 83c4fe0ab6f49adfa36a017bba3fc25f82a7647e Mon Sep 17 00:00:00 2001 From: Aaron Sherrill Date: Tue, 9 Oct 2018 11:09:31 -0400 Subject: [PATCH 5/5] Actually committing the small tweak to indendation of contributors --- package.json | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 8f90784..9242050 100644 --- a/package.json +++ b/package.json @@ -24,18 +24,18 @@ "name": "SiƓn Le Roux", "email": "sinisterstuf@gmail.com" }, - { - "name": "Mike Garuccio", - "url": "https://github.com/mgaruccio" - }, - { - "name": "Karel Piwko", - "url": "https://github.com/kpiwko" - }, - { - "name": "Aaron Sherrill", - "url": "https://github.com/motionharvest" - } + { + "name": "Mike Garuccio", + "url": "https://github.com/mgaruccio" + }, + { + "name": "Karel Piwko", + "url": "https://github.com/kpiwko" + }, + { + "name": "Aaron Sherrill", + "url": "https://github.com/motionharvest" + } ], "scripts": { "test": "node node_modules/mocha/bin/mocha"