Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate google response data #497

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Validate google response data #497

merged 2 commits into from
Jul 14, 2023

Conversation

smoy
Copy link
Contributor

@smoy smoy commented Jul 14, 2023

What changed?

  • Validate google response data prior to generate template

Rationale

  • To debug Google Workspace group member not having email address

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@smoy smoy self-assigned this Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01 ⚠️

Comparison is base (faa48ba) 85.75% compared to head (2e9116a) 85.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   85.75%   85.74%   -0.01%     
==========================================
  Files         102      102              
  Lines       11630    11637       +7     
==========================================
+ Hits         9973     9978       +5     
- Misses       1657     1659       +2     
Flag Coverage Δ
functional_tests 67.61% <87.50%> (+0.13%) ⬆️
functional_tests_config_discovery 47.26% <87.50%> (+0.02%) ⬆️
unit_tests 75.79% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bic/plugins/v0_1_0/google_workspace/group/utils.py 79.89% <87.50%> (-0.86%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@smoy smoy requested a review from castrapel July 14, 2023 21:32
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoy smoy merged commit e58f088 into main Jul 14, 2023
4 checks passed
@smoy smoy deleted the origin/debug-google-workspace branch July 14, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants