feat: 重构 Noneflow #231
Merged
feat: 重构 Noneflow #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 98.13% 91.16% -6.98%
==========================================
Files 17 34 +17
Lines 966 1494 +528
==========================================
+ Hits 948 1362 +414
- Misses 18 132 +114 ☔ View full report in Codecov by Sentry. |
he0119
requested changes
Oct 19, 2024
docker/docker_plugin_test.py
Outdated
.github/workflows/main.yml
Outdated
| @@ -32,10 +32,10 @@ jobs: | |||
| with: | |||
| token: ${{ secrets.CODECOV_TOKEN }} | |||
|
|
|||
| docker: | |||
| noneflow-docker: | |||
.github/workflows/docker-test.yml
Outdated
| uses: docker/build-push-action@v5 | ||
| with: | ||
| file: ./docker/Dockerfile | ||
| context: . |
There was a problem hiding this comment.
这里把 context 放到 ./docker 就可以了吧，file 参数可以直接删掉。
docker/Dockerfile
Outdated
|
|
||
| WORKDIR /tmp | ||
|
|
||
| COPY ./docker/docker_plugin_test.py /tmp/plugin_test.py |
There was a problem hiding this comment.
Suggested change
| COPY ./docker/docker_plugin_test.py /tmp/plugin_test.py | |
| COPY ./docker_plugin_test.py /tmp/plugin_test.py |
| else: | ||
| test_result = await DockerPluginTest( | ||
| DOCKER_IMAGES, project_link, module_name, config | ||
| ).run("3.10") |
| "load": plugin_test_output, | ||
| "metadata": metadata, | ||
| }, | ||
| test_env={test_env: True}, |
| ISSUE_FIELD_TEMPLATE = "### {}" | ||
| ISSUE_FIELD_PATTERN = r"### {}\s+" | ||
|
|
||
| SKIP_COMMENT = "/skip" |
src/plugins/github/constants.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| NONEFLOW_MARKER = "<!-- NONEFLOW -->" | |||
|
|
|||
| BOT_MARKER = "[bot]" | |||
| ) | ||
| from githubkit.typing import Missing | ||
|
|
||
| IssuesEvent: TypeAlias = ( |
There was a problem hiding this comment.
pydantic 如果不支持 type 的话，可以临时禁用这个规则。
he0119
reviewed
Oct 22, 2024
src/providers/store_test/__main__.py
Outdated
|
|
||
| # 通过环境变量传递插件配置 | ||
| config = os.environ.get("PLUGIN_CONFIG") | ||
| data = os.environ.get("PLUGIN_DATA") | ||
|
|
||
| asyncio.run(test.run(key, config, data)) | ||
| if key and (config or data): |
he0119
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
架构:
商店:
交互: