Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation/plugin quick start] Wrong paths #113

Open
ChristinaMariaMayrBirg opened this issue Sep 9, 2024 · 2 comments
Open

[Documentation/plugin quick start] Wrong paths #113

ChristinaMariaMayrBirg opened this issue Sep 9, 2024 · 2 comments

Comments

@ChristinaMariaMayrBirg
Copy link

I used the quick start example provided here:
https://nomad-lab.eu/prod/v1/docs/howto/oasis/plugins_install.html

When I wanted to start the app container
docker compose up app
I got an error message because the paths in the docker-compose.plugins.yaml were set wrong.

services:
  worker:
    volumes:
      - ./nomad-schema-plugin-example/nomadschemaexample:/app/plugins/nomadschemaexample
      - ./nomad-parser-plugin-example/nomadparserexample:/app/plugins/nomadparserexample
      - ./nomad-normalizer-plugin-example/nomadparserexample:/app/plugins/nomadparserexample # should be normalizer not parser
  app:
    volumes:
      - ./nomad-schema-plugin-example/nomadschemaexample:/app/plugins/nomadschemaexample
      - ./nomad-parser-plugin-example/nomadparserexample:/app/plugins/nomadparserexample
      - ./nomad-normalizer-plugin-example/nomadparserexample:/app/plugins/nomadparserexample  #should be normalizer not parser

I got the container started after correcting the paths:

services:
  worker:
    volumes:
      - ./nomad-schema-plugin-example/nomadschemaexample:/app/plugins/nomadschemaexample
      - ./nomad-parser-plugin-example/nomadparserexample:/app/plugins/nomadparserexample
      - ./nomad-normalizer-plugin-example/nomadnormalizerexample:/app/plugins/nomadnormalizerexample 
  app:
    volumes:
      - ./nomad-schema-plugin-example/nomadschemaexample:/app/plugins/nomadschemaexample
      - ./nomad-parser-plugin-example/nomadparserexample:/app/plugins/nomadparserexample
      - ./nomad-normalizer-plugin-example/nomadnormalizerexample:/app/plugins/nomadnormalizerexample  
@lauri-codes
Copy link
Contributor

@ChristinaMariaMayrBirg: Thanks for picking up this problem in the docs. As mentioned in the docs, this way of installing plugins is deprecated, and we will actually remove this whole section from the docs in an upcoming release.

The problem with simply mounting packages is that the possible dependency conflicts are not resolved, and some of the actions performed during a typical pip install <package-nam> are missing. I would recommend either options 1. or 2. mentioned on the same page.

@ChristinaMariaMayrBirg
Copy link
Author

I followed version 1 of the updated documentation. I get the following error when I use the template:

FAIRmat-NFDI/nomad-distribution-template#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants