-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical property initliazation #129
Comments
Yeah, I think this is the weakest point of the dynamical shape. I guess doing a default could work, can you give me a specific example where this breaks? |
This does not work: dct = {'electronic_eigenvalues': [{'n_bands': 3}]}
out = Outputs.m_from_dict(dct) error
|
I am having a different error with your code: from nomad_simulations.schema_packages.outputs import Outputs
dct = {'electronic_eigenvalues': [{'n_bands': 3}]}
out = Outputs.m_from_dict(dct) ValueError: `n_bands` is not defined during initialization of the class. |
ah yeah I forgot to remove the other fix I put in. |
While you break it again, I think this is going to be handled different anyways, so I am sure redefining |
i am not sure but can we not use the |
|
in metainfo.py |
The initialization of PhysicalProperty objects may require quantities to be defined such as in
BaseElectronicEigenvalues
, where nbands needs to be specified. This will not work with the mapping parser for we can only set the quantity after creating the section. Is is possible then to either 1. put a default for these required quantities or 2. make the quantities that depend on these required quantites as derived quantites.@JosePizarro3
The text was updated successfully, but these errors were encountered: