Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

242 cp2k parser failing at process #243

Merged
merged 5 commits into from
Sep 2, 2024
Merged

242 cp2k parser failing at process #243

merged 5 commits into from
Sep 2, 2024

Conversation

ndaelman-hu
Copy link
Contributor

  • Add support for missing "PROCESS ID" at the end.
  • Fix void assignment of plane-wave cutoff.

Closes #242

@ndaelman-hu ndaelman-hu added the bug Something isn't working. It also represents a quick fix in response to a bug. label Aug 30, 2024
@ndaelman-hu ndaelman-hu self-assigned this Aug 30, 2024
@ndaelman-hu
Copy link
Contributor Author

@aalbino2 Don't worry about the failing tests: you'll see that they're bugs in other parsers.

@ndaelman-hu
Copy link
Contributor Author

  • [] TODO: add testing for both fixes.

Maybe I'll re-open this PR later and add it then?

aalbino2
aalbino2 approved these changes Sep 2, 2024
View reviewed changes
Copy link

@aalbino2 aalbino2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ndaelman-hu ndaelman-hu force-pushed the 242-cp2k-parser-failing-at-process-id branch from c9d2706 to cfe2245 Compare September 2, 2024 10:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10666476744

Details

  • 22 of 25 (88.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.037%
Changes Missing Coverage Covered Lines Changed/Added Lines %
electronicparsers/cp2k/parser.py 14 17 82.35%
Totals Coverage Status
Change from base Build 10664082751: 0.0%
Covered Lines: 35744
Relevant Lines: 38419
💛 - Coveralls

@ndaelman-hu ndaelman-hu merged commit 4222647 into develop Sep 2, 2024
4 checks passed
@ndaelman-hu ndaelman-hu deleted the 242-cp2k-parser-failing-at-process-id branch September 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalbino2 aalbino2 aalbino2 approved these changes

@ladinesa ladinesa Awaiting requested review from ladinesa

Assignees

@ndaelman-hu ndaelman-hu

Labels
bug Something isn't working. It also represents a quick fix in response to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CP2K parser failing at PROCESS ID
4 participants
@ndaelman-hu @coveralls @aalbino2 @ndaelman