Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdf5 references #214

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Update hdf5 references #214

merged 4 commits into from
Apr 19, 2024

Conversation

ladinesa
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks for taking care of this.

Btw, this will eventually change with the HDFDataset and the new schema. How does it work if we have more than 1 quantity with this type? Does it define a global hdf5 file where it stores this as a dataset? Or it creates as many hdf5 files as needed? I think the second option might not be optimal.

@ladinesa
Copy link
Collaborator Author

Very good, thanks for taking care of this.

Btw, this will eventually change with the HDFDataset and the new schema. How does it work if we have more than 1 quantity with this type? Does it define a global hdf5 file where it stores this as a dataset? Or it creates as many hdf5 files as needed? I think the second option might not be optimal.

There is only one hdf5 for every entry juat like the atchive.

@ladinesa ladinesa merged commit 59952c7 into develop Apr 19, 2024
4 checks passed
@ladinesa ladinesa deleted the update-hdf5 branch April 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants