Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nomad dependency #211

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Fix nomad dependency #211

merged 3 commits into from
Mar 13, 2024

Conversation

ladinesa
Copy link
Collaborator

No description provided.

@ladinesa ladinesa requested a review from blueraft March 12, 2024 15:22
blueraft
blueraft approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@blueraft blueraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Perhaps worth mentioning this step in the README in the local development section.

@ladinesa
Copy link
Collaborator Author

Looks good to me.

Perhaps worth mentioning this step in the README in the local development section.

will include in the nomad mr, waiting for approval from @JosePizarro3 for other parsers.

JosePizarro3
JosePizarro3 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you check the setup script in NOMAD with these changes? 🙂

Thanks a lot!

.github/workflows/python-actions.yaml Show resolved Hide resolved
This was referenced Mar 12, 2024
Merged
Merged
@ladinesa ladinesa merged commit 51ba205 into develop Mar 13, 2024
4 checks passed
@ladinesa ladinesa deleted the package branch March 13, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosePizarro3 JosePizarro3 JosePizarro3 approved these changes

@blueraft blueraft blueraft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladinesa @blueraft @JosePizarro3