Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Have implementation of BaseOfficeFile's functions support any parameters #87

Open
gdesmar opened this issue Mar 7, 2024 · 0 comments

Comments

@gdesmar
Copy link
Contributor

gdesmar commented Mar 7, 2024

The BaseOfficeFile defines three functions that can be implemented. If we look at load_key(), doc97, ppt97 and xls97 take the same arguments and behave similarly. Looking at ooxml, it takes more arguments and does not validate the password (if provided) by default. As I want to validate the password, I cannot call the function load_key() in an agnostic way.
Do you think it would be valuable to catch extra parameters in all implementations of load_key() and decrypt() with *args + **kwargs to make it more uniform?
I can see the downside of a user passing parameters that are ignored, and not understanding why it does nothing, so I do not have strong feelings on this suggestion.
Thank you for your time! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants