Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateString CreateArray CreateNumber #6

Open
forresto opened this issue May 5, 2014 · 3 comments
Open

CreateString CreateArray CreateNumber #6

forresto opened this issue May 5, 2014 · 3 comments

Comments

@forresto
Copy link
Member

forresto commented May 5, 2014

These components would be useful in the UI to have the correct IIP editor in the node inspector.

@djdeath
Copy link
Member

djdeath commented May 5, 2014

What would be the input of these components? Strings?

If so, why not put that into noflo-strings, we already have ParseFloat/ParseInt/ParseJson there.

@forresto
Copy link
Member Author

forresto commented May 6, 2014

No, they would have the correct input widget, so the parsing would be done
by the UI.

paulyoung added a commit to paulyoung/noflo-objects that referenced this issue May 13, 2014
@paulyoung
Copy link

I made a start (disclaimer, I'm new to FBP).

CreateArray seemed like it should work the same way as CreateObject so that's what I have so far.

I'd prefer to have tests for these but I'm not entirely sure what I need to cover. Maybe something like this?

test = require "noflo-test"

expected1 = []

test.component("objects/CreateArray").
  discuss("upon start").
    send.connect("start").
    send.data("start", null).
    send.disconnect("start").
  discuss("creates an empty array").
    receive.data("out", expected1).

export module

So, if CreateObject sends an empty object and CreateArray sends an empty array, what are we proposing that CreateString or CreateNumber send?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants