We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, it looks like the "error" status for load should call deferred.reject() and not deferred.fail()
load
deferred.reject()
deferred.fail()
featherlight/src/featherlight.js
Line 398 in c4ed123
I am using it like this:
var modal = new $.featherlight("/my-uri") var p = modal.open() p.fail(function() { console.log("fail callback") })
If the URL provided is a 404 for example, the fail callback does not get fired because you don't reject the deferred object.
404
fail
reject
The text was updated successfully, but these errors were encountered:
Good catch. Would you be kind enough to provide a PR?
Sorry, something went wrong.
marcandre
No branches or pull requests
Hi, it looks like the "error" status for
load
should calldeferred.reject()
and notdeferred.fail()
featherlight/src/featherlight.js
Line 398 in c4ed123
I am using it like this:
If the URL provided is a
404
for example, thefail
callback does not get fired because you don'treject
the deferred object.The text was updated successfully, but these errors were encountered: