Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] win,tools: upgrade Windows signing to smctl #51116

Closed
wants to merge 1 commit into from
Closed

[v20.x backport] win,tools: upgrade Windows signing to smctl #51116

wants to merge 1 commit into from

Conversation

StefanStojanovic
Copy link
Contributor

As a part of the new signing requirements for Windows, this changes the approach to using the DigiCert cloud HSM service KeyLocker. This change already landed on the main branch in this PR. This is just a port to the LTS version needed for future releases.

Refs: nodejs/build#3491

@StefanStojanovic
win,tools: upgrade Windows signing to smctl
bfc9c84 
As a part of the new signing requrements for Windows change approach to
use the DigiCert cloud HSM service KeyLocker.

PR-URL: nodejs#50956
Fixes: nodejs/build#3491
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. windows Issues and PRs related to the Windows platform. labels Dec 11, 2023
@StefanStojanovic StefanStojanovic changed the title win,tools: upgrade Windows signing to smctl v20 [v20.x backport] win,tools: upgrade Windows signing to smctl Dec 11, 2023
richardlau
richardlau approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/releasers It's possible the original commit will cherry-pick cleanly but I'm approving this backport in case it doesn't and we need to land before the usual "two weeks in current".

Please note that the Windows signing certificate we have been using expires on 18 December 2023 (nodejs/build#3491) so any new releases should include this PR so that they start using the new certificate.

@StefanStojanovic
Copy link
Contributor Author

It's possible the original commit will cherry-pick cleanly

This was created by cherry-pick, so it should work. I wasn't aware of any policy for backporting commits to LTS branches, so I opened this PR. In case there is another way feel free to let me know how I should do it. Thanks in advance.

@richardlau richardlau mentioned this pull request Dec 14, 2023
Merged
@UlisesGascon UlisesGascon force-pushed the v20.x-staging branch 2 times, most recently from 4c9099f to 7af8e20 Compare December 20, 2023 15:15
@StefanStojanovic
Copy link
Contributor Author

Since this change was already ported in #51124, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanStojanovic @richardlau @nodejs-github-bot