Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix rendering of code blocks in list #1401

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 2, 2023

Without proper indentation, some paragraphs would be rendered as code blocks:

screenshot showing incorrect rendering

@tniessen tniessen added the doc label Nov 2, 2023
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

doc/setup.md Outdated Show resolved Hide resolved
doc/setup.md Outdated Show resolved Hide resolved
Co-authored-by: Chengzhong Wu <[email protected]>
@tniessen
Copy link
Member Author

tniessen commented Nov 3, 2023

CI keeps failing with No module named 'distutils'

@tniessen
Copy link
Member Author

tniessen commented Nov 3, 2023

Likely due to nodejs/node-gyp#2869. How do we upgrade node-gyp to pull in nodejs/node-gyp#2923?

@legendecas
Copy link
Member

Locking python version in GitHub actions: #1403

@legendecas
Copy link
Member

node-gyp is bundled with npm. npm v10 dropped support for Node.js v14 and v16. So I'm going to simply lock the python version on GitHub actions, to avoid breakage in the future as well.

@legendecas legendecas merged commit 734e3f2 into nodejs:main Nov 7, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants