Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix macos install guide #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

foray1010
Copy link

--with-lldb --with-toolchain are removed from https://github.com/Homebrew/homebrew-core/blob/master/Formula/llvm.rb

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #373 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   79.53%   78.98%   -0.55%     
==========================================
  Files          33       33              
  Lines        4744     4744              
==========================================
- Hits         3773     3747      -26     
- Misses        971      997      +26     
Impacted Files Coverage Δ
src/llv8.cc 71.71% <0.00%> (-2.29%) ⬇️
src/llv8.h 81.81% <0.00%> (-2.28%) ⬇️
src/llv8-constants.h 97.05% <0.00%> (-1.48%) ⬇️
src/llv8-inl.h 90.42% <0.00%> (-0.82%) ⬇️
src/llv8-constants.cc 85.92% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b868f7...a316b85. Read the comment docs.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@No9 No9 mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants