Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure due to spaces in path #180

Open
recrsn opened this issue Oct 6, 2022 · 1 comment
Open

Build failure due to spaces in path #180

recrsn opened this issue Oct 6, 2022 · 1 comment

Comments

@recrsn
Copy link

recrsn commented Oct 6, 2022

When installing a native module using node-gyp, commands fail to run if there is a space in the path anywhere of the CWD.

A CWD like /home/abc/My Awesome Repo/project will fail.

This has been discussed here: kelektiv/node.bcrypt.js#961
and here: nodejs/node-gyp#65

And has been found to be an underlying issue with gyp itself

@recrsn
Copy link
Author

recrsn commented Oct 6, 2022

There is also a potential fix here: nodejs/node-gyp#2556

but the PR targets the vendored gyp code in node-gyp. It should belong here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant