ansible: fix v8-canary SHASUMS256.txt #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3951 should land first (there will be a conflict) |
Shasums for v8-canary builds were being uploaded to `nodejs/v8-canary/...` path in the `dist-staging` bucket instead of the `nodejs/custom/...` path Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/20241107/fix-v8-canary-shasums
branch
from
3c9cea9
to
e6c1dcf
Compare
targos
approved these changes
Nov 8, 2024
targos
added a commit
to targos/nodejs-build
that referenced
this pull request
Nov 8, 2024
It needs it after nodejs#3953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shasums for v8-canary builds were being uploaded to
nodejs/v8-canary/...path in thedist-stagingbucket instead of thenodejs/custom/...path. This makes them now be uploaded to thenodejs/custom/...path.