Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: use buildpack instead of Dockerfiles #3775

Closed
trivikr opened this issue Jun 23, 2024 · 4 comments
Closed

metrics: use buildpack instead of Dockerfiles #3775

trivikr opened this issue Jun 23, 2024 · 4 comments

Comments

@trivikr
Copy link
Member

trivikr commented Jun 23, 2024

Is your feature request related to a problem? Please describe.

The metrics code run on Google Cloud Run is managed using Dockerfile.

These Dockerfiles need to be managed while upgrading Node.js, or making any other changes in application.
For example, here is a PR which upgrades Node.js versions from 14 to 20 #3767

Describe the solution you'd like

Use buildpack instead of Dockerfiles
https://cloud.google.com/docs/buildpacks/build-application#node.js

@targos
Copy link
Member

targos commented Jun 23, 2024

I'm not sure it's an advantage tbh

@trivikr
Copy link
Member Author

trivikr commented Jun 23, 2024

The only advantage would be the absence of Dockerfiles in the source code.
The Node.js version is only required to be defined in package.json, and buildpack will handle managing the version.

@targos
Copy link
Member

targos commented Jun 25, 2024

The only advantage would be the absence of Dockerfiles in the source code.

That's what I don't see as an advantage. Cloud run works with Docker containers, and for the majority of developers, containers are built using Dockerfiles, not some obscure (to me at least) Google tool.

@trivikr
Copy link
Member Author

trivikr commented Jun 25, 2024

I agree. It's better to stick with Dockerfiles since:

  • It's a standard for building containers in the industry. If the setup is moved to another container solution on GCP or some other cloud, it'll be easy to migrate Dockerfiles.
  • Using a Dockerfile is the first recommendation for building containers in GCP documentation (before buildpack)

@trivikr trivikr closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants