-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoongArch to Experimental tier (CI environment) #3540
Comments
@sxa #3511 (comment)
LoongArch platform can follow up the latest status of node, solve problems in the process, and promote the development of loong64-node.
OS: LoongArch Fedora remixlatest v18/v20/mainwget -c https://nodejs.org/download/release/latest-v18.x/node-v18.18.2.tar.gz may need to apply this patchnodejs/node#50209 build
check
latest-v18/latest-v20/mainThe latest test-ci-js version of v18/v20/main failed 3 tests
latest-v18(1) time make -j4
(2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
latest-v20(1) time make -j4
(2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
main(1) time make -j4
(2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
There are two questions about the way LoongArch machine is provided, hope you can help me, thanks~ Best regards @nodejs/build @mhdawson @richardlau @sxa @targos |
The machine must be able to run the Jenkins agent (Java 11 or 17) |
21'should also be acceptable now - I can't remember if the loongarch support was backported to JDK17 |
Yes, the running system is java17.
|
There is still one question about the way of providing LoongArch machine, look forward to node-loong64 running successfully in the official CI process, thanks~ |
I think access by IP address and SSH is all we need to manage it and connect it to Jenkins. |
Then it could be part of a nightly job like https://ci.nodejs.org/view/All/job/sxa-rvnodetest/ |
Ok, thank you for your answer. I will prepare the machine and the user password for accessing the LoongArch machine using ssh in these two days. Best regards |
In terms of configuring access we use ssh keys, it would be better if we could send you a public key that you can added to the machine versus a userid/password. |
It is possible to add a public key. I will tell you here after I configure the machine. I can help you put the public key into the nodejs-LoongArch machine. Best regards |
@nodejs/build @mhdawson @richardlau @sxa @targos @nodejs/platform-loong64 There are two questions about the way LoongArch machine is provided, hope you can help me, thanks~
Best regards |
Hello, everyone OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gz
check nodejs/node 20231101-main
(2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards Can you guide me on what to do next? Thank you~ @nodejs/build @mhdawson @richardlau @sxa @targos @nodejs/platform-loong64 |
Sorry for my a little too many questions, I would like to ask how "sxa-rvnodetest" accesses CI nodes, thank you Best regards |
Not sure I understand the question - like all jobs the rv-nodetest one specifies a label for machines to run on under "Restrict where this job can run", and the RISC-V machines that are connected to the CI have that label on it. |
Thanks for reply I have a LoongArch machine ready, but I don't know how to connect this LoongArch to CI Best regards |
Unfortunately I haven't got any spare time to dedicate to this, and @mhdawson is not around this week, but I will send you the public ssh key that the build/infra team uses to connect into the machines via a slack DM, so if you can ensure root logins are allowed and put this key in the root accoun that would be a good starting point :-) |
Ok, thank you very much for your reply Best regards |
Thanks, I have received the public-key of "[email protected]" on slack, and I am going to put it into the system. Best regards |
[email protected] public key has been added. In what way are the IP addresses and network ports of LoongArch machines submitted, New ARCH submission PR Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gz
check nodejs/node 20231106-main20231106 main : have one failures in the main test
(2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
I'll take a look once I'm back in the office after NodeConf.eu next week. |
Okay, thank you. Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231107-main20231107 main : have one failures in the main test
20231107 main(1) time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231108-main20231108 main : have one failures in the main test
20231108 main
(1) time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231109-main20231109 main : have one failures in the main test
20231109 main
(1) time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231110-main20231110 main : have one failures in the main test
20231110 main
(1) ./configure --openssl-no-asm; time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231111-main20231111 main : have one failures in the main test
20231111 main
(1) ./configure --openssl-no-asm; time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231112-main20231112 main : have one failures in the main test
20231112 main
(1) ./configure --openssl-no-asm; time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
OS (clfs): Yongbao-2.3-for-nodejs-ci.tar.gzcheck nodejs/node 20231113-main20231113 main : have one failures in the main test
20231113 main
(1) ./configure --openssl-no-asm; time make -j32 (2) time make test-ci-js 2>&1 | tee ../E.log-nodejs-ci
Best regards |
20240222: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/99/console Yay! |
Hi, Now the ci of nodejs-loong64 has passed successfully, what should I do next to promote nodejs-loong64 to become Tier-2? What do I need to do next to move forward. Thank you. Best regards |
Hi, 20240223: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/101/console Best regards |
Hi, 20240224: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/102/console Best regards |
Hi, 20240225: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/105/console Best regards |
Hi, 20240226: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/107/console Best regards |
Hi, 20240227: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/108/console Best regards |
Hi, 20240228: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/109/console Best regards |
Hi, 20240229: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/110/console Best regards |
Hi, 20240301: CI passed successfully: https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/111/console Best regards |
@shipujin I'm not sure you need to post for each passing run. Intead it could make sense to post if there are failures and you need help to resolve, or as a heads up that you are working to resolve. |
Sorry, this is my fault and I will correct it. Now I have a question, the ci of nodejs-loong64 has passed successfully, what should I do next to promote nodejs-loong64 to become Tier-2? What do I need to do next to move forward. Thank you. Best regards |
The next step would be to have more hardware in the CI so that it could be part of every CI run. I think that would also require you/somebody from your team to get involved in the build WG to help support those machines. |
Thank you for your help~
We are very excited to promote nodejs-loong64, and I will provide feedback to my leadership to add more machine nodes to CI. I would like to ask how many machines are needed to join CI. I understand these so that I can apply for machines with my leader.
I'm very happy to join the build-WG to help nodejs-loong64 become an official support structure and help these machines run. Best regards |
To test on every PR we typically need at least 3 machines and they should be fast enough that they complete within ~ 30 mins or so.
If possible I suggest you start by joining the Build WG meetings which are in the calendar (nodejs.org/calendar) , and and issue is created in the repo a few days in advance in https://github.com/nodejs/build. The next meeting is Mar 12 at 9ET -> #3646 |
Okay, thank you for your careful answer. I will apply with my leader to add the machine to CI.
ok, I will submit an issue to apply to join build-WG laterhttps://github.com//issues/3647. I will also pay attention to the working group meetings, but my English speaking is not good, but it does not affect my ability to solve and respond to problems in github/nodejs or email. I will We will continue to promote the growth of nodejs-loong64 and solve the problems that arise. Best regards |
Hi, Now I have successfully applied for 2 LoongArch servers, which can be provided to Node.js-CI remotely. Could you please provide me the public IP of Node.js-CI? I want to add the public IP of remote access by the Node.js-CI machine to the whitelist. Best regards |
@shipujin there are quite a few different IPs in our infra. Do you mean the jenkins server? The agents running on the test nodes reach out to the Jenkins server so I don't think you necessarily need to add it to your allowlist. In case you do need it all of the IPs are in - https://github.com/nodejs/build/blob/main/ansible/inventory.yml On the other hand we do want build members to be able to ssh into the machines and we each some from different places |
Thank you for your reply.
Sorry for my misunderstanding. If LoongArch test machine connects to jenkins server, jenkins does not need to be whitelisted.
Yes, I agree with your suggestion that build members should be able to ssh log in to the new LoongArch test machine, but our room network administrator requires to add whitelist and increase security. Sorry, I haven't thought of other better ways to solve this problem. There will be optimized plans in the future, and I will update them in time. Best regards |
I think we'd need something like a jump machine that can be in the whitelist. Build WG members connect to the jump machine and then into the LoongArch machines. What I'm not sure of is how we make that with Ansible. @richardlau any thoughts on that? |
Not sure. Rod set up the one we used to use for the Pi's -- I can't remember if the set up for that was in Ansibile. |
I have prepared two LoongArch servers. What should I do to add them to Node.js-CI? Best regards |
Can you PR the ips ito the inventory here - https://github.com/nodejs/build/blob/main/ansible/inventory.yml and add the public test key to the services so we can ssh in? I guess that gets us back to the earlier question of access. How about you get I assume you have already run ansible on them to configure them, if so once I have access and know their ips from the inventory I can add them to jenkins, add the jenkins tokens to the machines. @richardlau I don't think that machine is used too much, but wanted to check if you know its going to go away any time soon? |
I'm not aware of anything affecting that server's availability on the horizon. |
Ok, I will submit the pr, thank you
Ok, I'll talk to the room administrator and add Best regards |
Sorry that the network of the computer room is being adjusted, I will repair the network as soon as possible and promote the network recovery as soon as possible. Best regards |
I would like to discuss here how to put LoongArch machine access nodejs/build CI environment, test machine for LoongArch nodejs.
Best regards
The text was updated successfully, but these errors were encountered: