Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive towards full coverage #431

Open
mhdawson opened this issue Nov 12, 2021 · 6 comments
Open

Drive towards full coverage #431

mhdawson opened this issue Nov 12, 2021 · 6 comments
Milestone

Comments

@mhdawson
Copy link
Member

Next steps
1- Blog post to point to the issues we have open to encourage external help.

@mhdawson
Copy link
Member Author

@JckXia has a draft for the blog post, will send to rest of team members through email to discussion/review.

@mhdawson
Copy link
Member Author

Link with blog post for commenting/editing https://docs.google.com/document/d/1uqy-DGRks6RMO3xPVx1Iyywk7h6rSdGg/edit

@KevinEady
Copy link
Contributor

@KevinEady to investigate adding a coverage badge to the root README.md.

@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2024

Badge is now on README.md

@KevinEady
Copy link
Contributor

Next step: Create a "condensed report" which analyzes why some coverage paths are not taken and present this to team for triage.

@KevinEady
Copy link
Contributor

  • Investigate why coverages is lower than expected: is it possible that coverages are being overwritten? Coverages are stored on the filesystem when the process runs (ends?). Could it be the case that since we use subprocesses, a subprocess' test results get overridden when the parent process' finishes?
  • Improve coverage report with experimental runs node-addon-api#1525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants