Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc and style changes #138

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Doc and style changes #138

merged 4 commits into from
Aug 2, 2024

Conversation

k-doering-NOAA
Copy link
Collaborator

Partially addresses #136 and #137 by:

  • Adding examples that illustrate options for the doc and style workflow
  • Adding an error message for having doc and style run on pull requests and submit a pull request, since @iantaylor-NOAA found this combo to not work.

Additionally, this corrects outdated documentation suggesting that the rm_dollar_sign function was in the {r4ss} pkg; it is in {ghactions4r}.

@iantaylor-NOAA , I thought you would be best to review this, but perhaps @Bai-Li-NOAA can review if you are not able to!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (2695d1a) to head (b4df853).

Files Patch % Lines
R/use_r_workflows.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   95.47%   95.02%   -0.46%     
==========================================
  Files           3        3              
  Lines         199      201       +2     
==========================================
+ Hits          190      191       +1     
- Misses          9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making these changes so quickly @k-doering-NOAA.
I will stop posting issues on ghactions4r for a while.

@k-doering-NOAA
Copy link
Collaborator Author

Thanks for reviewing @iantaylor-NOAA !

@Bai-Li-NOAA will be maintaining ghactions4r over the next few months :)

@k-doering-NOAA k-doering-NOAA merged commit e567c26 into main Aug 2, 2024
10 checks passed
@k-doering-NOAA k-doering-NOAA deleted the doc-and-style-changes branch August 2, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants