Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better workflow for adding new ghactions #127

Open
k-doering-NOAA opened this issue Jun 3, 2024 · 0 comments
Open

better workflow for adding new ghactions #127

k-doering-NOAA opened this issue Jun 3, 2024 · 0 comments

Comments

@k-doering-NOAA
Copy link
Collaborator

Thanks @Bai-Li-NOAA for identifying this.

On #121 @Bai-Li-NOAA noted that the tests fail initially before merging into main, which is expected. Perhaps we should change how our tests work so that they aren't expected to fail when new reusable workflows are added.

I assume the failed checks on the pull request will run successfully after merging the changes into the main branch. I wonder if the errors from local checks can be resolved by writing custom expectations (e.g., expect_proj_file()). I've seen some examples in the {usethis} tests, but the utility functions for the active project seem very complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant