Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit status 0 when prererendering fails #362

Open
oscartbeaumont opened this issue Sep 1, 2024 · 0 comments
Open

Exit status 0 when prererendering fails #362

oscartbeaumont opened this issue Sep 1, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@oscartbeaumont
Copy link

I am running vinxi build on a Solid Start app and I have a bug in my code where I access window.

The bug itself is fine, however I noticed that the Vinxi process returns the 0 exit code which should only be used to indicate success.

If I run pnpm build && echo $? I see 0 where I would expected a non-zero exit code.

This matters because it's common for CI processes to use the status to determine if it should continue executing.
@nksaraf nksaraf added the good first issue Good for newcomers label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nksaraf @oscartbeaumont