Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets incorrectly loaded from unrelated page #326

Open
lominming opened this issue Jul 9, 2024 · 1 comment
Open

Assets incorrectly loaded from unrelated page #326

lominming opened this issue Jul 9, 2024 · 1 comment

Comments

@lominming
Copy link

Scenario is that I have a solid-js start application (SSR enabled).

I have pages in the routes folder (e.g. index and admin/page). However, when I load index, I am seeing that js files from the admin/page is being loaded. In another words, loading the index page is also loading assets from other routes/pages!

Tracing back the issue all the way back to createPageEvent in pageEvent.js of @solidjs/start. It appears that import.meta.env.MANIFEST["client"] and import.meta.env.MANIFEST["ssr"] could have wrongly loaded assets for the page. I checked that Vinxi seems to be the one populating the 2 global variables. Can you provide any additional assistance as to where I could try to trace the issue?

Any ideas why a page is loading assets from other unrelated page?

@lominming
Copy link
Author

lominming commented Jul 9, 2024

I am tracing to see why the assets are wrongly loaded, and I noticed that some js files are unnecessary added in the MANIFEST.

Specifically: virtual:$vinxi/handler/client has some external imports that I do not think should be there.

How are the imports for virtual:$vinxi/handler/client determined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant