Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endianness should be flipped at set AND get #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicoinn
Copy link

@nicoinn nicoinn commented Apr 8, 2019

Endianness of major, minor and manufacturerID are swapped upon calling the corresponding set method, but they are not swapped back when calling the get.

Example code to demonstrate the issue

Beacon.setMajor(0xABCD);
Serial.printf("TEST: 0x%02x -- Should be 0x%02x\n",oBeacon.getMajor(),0xABCD);

Will print
TEST: 0xcdab -- Should be 0xabcd

This patches re-establishes the original endianness while called the get method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant