Compile with 1.6+ and run with 1.5+ #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://groups.google.com/group/asynchttpclient/browse_thread/thread/ad594c12c9fc498d?hl=en In summary: 1. We now "require" JDK 1.6 for "compilation". This ensures we use recent compiler. 2. We produce byte code compatible with JRE 1.5. Thus, if any user is using JRE 1.5 s/he does not need to upgrade to 1.6+. 3. Source is 1.5 and so is target. This means we treat the source code to be compatible with 1.5. 4. Any 1.6 language constructs (e.g. @OverRide on interface methods) and library constructs (e.g. any 1.6-only JDK classes/methods) are detected at compile time and build fails if any are found. This ensures that the 1.6 compiled sources will run on JRE 1.5 (and not fail with RuntimeException). Use of animal sniffer enables this. Tested on Linux.
|
Thanks for the contribution! I will do some test and integrate! |
|
Thanks. I think I need to change the POM to add a repo. Will do that or you can do that after pulling it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that we compile with 1.6+ and can run with 1.5+ JRE.
Please see the commit comments.