Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integrate] As a user, I can see dialog when there is no internet connection #102

Open
kaungkhantsoe opened this issue Aug 2, 2023 · 0 comments · May be fixed by #105
Open

[Integrate] As a user, I can see dialog when there is no internet connection #102

kaungkhantsoe opened this issue Aug 2, 2023 · 0 comments · May be fixed by #105
Assignees
@kaungkhantsoe
Labels
type : feature

Comments

@kaungkhantsoe
Copy link
Contributor

Why

When there is no internet connection, it shows no internet connection dialog.

Acceptance Criteria

The following features should be available for every screen

  • Show dialog when there is no internet connection
  • If there is already a no internet connection dialog, do not show a duplicate dialog

The feature should be global.
@kaungkhantsoe kaungkhantsoe self-assigned this Aug 2, 2023
kaungkhantsoe added a commit that referenced this issue Aug 2, 2023
@kaungkhantsoe
[#102] Integrate implementation for no connection dialog
fd3afad
@kaungkhantsoe kaungkhantsoe linked a pull request Aug 2, 2023 that will close this issue
Open
@kaungkhantsoe kaungkhantsoe linked a pull request Aug 2, 2023 that will close this issue
[#102] [Integrate] As a user, I can see dialog when there is no internet connection #105
Open
kaungkhantsoe added a commit that referenced this issue Aug 3, 2023
@kaungkhantsoe
[#102] Add callback on click ok
61b6af5
kaungkhantsoe added a commit that referenced this issue Aug 3, 2023
@kaungkhantsoe
[#102] Integrate implementation for no connection dialog
00a4c89
kaungkhantsoe added a commit that referenced this issue Aug 3, 2023
@kaungkhantsoe
[#102] Add callback on click ok
9a89135
kaungkhantsoe added a commit that referenced this issue Aug 3, 2023
@kaungkhantsoe
[#102] Rename method names to be consistent and remove callback from …
f031f35 
…HomeScreen
kaungkhantsoe added a commit that referenced this issue Aug 7, 2023
@kaungkhantsoe
[#102] Remove viewModel from AppNavigation
2ea17a0
kaungkhantsoe added a commit that referenced this issue Aug 8, 2023
@kaungkhantsoe
[#102] Add ComposeCryptoApp
7d58e3a
kaungkhantsoe added a commit that referenced this issue Aug 11, 2023
@kaungkhantsoe
[#102] Resolve minor grammar issue
e38967c
kaungkhantsoe added a commit that referenced this issue Aug 25, 2023
@kaungkhantsoe
[#102] Update the method of showing global dialog with actions
d68a173
kaungkhantsoe added a commit that referenced this issue Aug 25, 2023
@kaungkhantsoe
[#102] Update the method of showing global dialog with actions and re…
f961999 
…solve minor review comments
kaungkhantsoe added a commit that referenced this issue Aug 29, 2023
@kaungkhantsoe
[#102] Update the method of showing global dialog with actions and re…
a3f5d4b 
…solve minor review comments
kaungkhantsoe added a commit that referenced this issue Dec 10, 2023
@kaungkhantsoe
[#102] Update isNetworkConnected to be StateFlow and add test
4b5bc67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaungkhantsoe kaungkhantsoe

Labels
type : feature
Projects
None yet
Milestone
No milestone
1 participant
@kaungkhantsoe