Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#224] Add VPC Endpoint Gateway to logs #225

Merged
merged 4 commits into from
Dec 1, 2023
Merged

[#224] Add VPC Endpoint Gateway to logs #225

merged 4 commits into from
Dec 1, 2023

Conversation

malparty
Copy link
Member

@malparty malparty commented Sep 20, 2023 •
edited
Loading

What happened 👀

  • Find the routing table of the private subnet
  • Add resource aws_vpc_endpoint with logs service and the private route table

Insight 📝

n/a

Proof Of Work 📹

image

@malparty malparty added the type : feature New feature or request label Sep 20, 2023
@malparty malparty added this to the 2.1.0 milestone Sep 20, 2023
@malparty malparty self-assigned this Sep 20, 2023
@malparty malparty changed the base branch from develop to bug/gh-220-fix-namespace-env-misused September 20, 2023 03:48
@malparty malparty marked this pull request as ready for review September 20, 2023 04:10
hoangmirs
hoangmirs reviewed Sep 20, 2023
View reviewed changes
templates/addons/aws/modules/vpc/main.tf Outdated Show resolved Hide resolved
templates/addons/aws/modules/vpc/main.tf Outdated Show resolved Hide resolved
@malparty malparty marked this pull request as draft September 20, 2023 07:36
@malparty malparty changed the title [#224] Add VPC Endpoint Gateway to S3 [#224] Add VPC Endpoint Gateway to logs Sep 20, 2023
Base automatically changed from bug/gh-220-fix-namespace-env-misused to develop September 29, 2023 11:21
@malparty malparty marked this pull request as ready for review November 22, 2023 04:17
@hoangmirs hoangmirs modified the milestones: 2.1.0, 2.3.0 Nov 30, 2023
@hoangmirs hoangmirs merged commit 9bd4688 into develop Dec 1, 2023
3 checks passed
@hoangmirs hoangmirs deleted the feature/gh-224-add-vpc-endpoint-to-s3 branch December 1, 2023 07:31
@hoangmirs hoangmirs mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nihisil Nihisil Nihisil approved these changes

@hoangmirs hoangmirs hoangmirs approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

@nvminhtue nvminhtue Awaiting requested review from nvminhtue nvminhtue is a code owner

@rosle rosle Awaiting requested review from rosle

@liamstevens111 liamstevens111 Awaiting requested review from liamstevens111 liamstevens111 is a code owner

Assignees

@malparty malparty

Labels
type : feature New feature or request
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Add VPC Endpoint Gateway to logs
3 participants
@malparty @Nihisil @hoangmirs