Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_dark_highlighting in posts if has code block #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use_dark_highlighting in posts if has code block #205

wants to merge 2 commits into from

Conversation

KingDarBoja
Copy link

Fixes #202

By the way, had to remove the gemfile.lock and the blog post with the .adoc extension to run it locally due to compilation errors.

@dom96
Copy link
Contributor

dom96 commented Jun 27, 2020

Why not enable it for all posts?

@KingDarBoja
Copy link
Author

KingDarBoja commented Jun 27, 2020

Why not enable it for all posts?

🤦‍♂️ I forgot the ones that didn't show up on my vscode search ```nim. Give me a few minutes and I will do it.

By the way, should the github.css be preserved as the main idea should be using the dracula highlight theme for the entire website? Just saying.

EDIT Maybe it isn't required for most posts as there are few ones without code blocks.

@narimiran
Copy link
Member

Can we make this work without the need to edit every single blogpost and adding use_dark_highlighting: true, i.e. can that be the default?

@Calinou Calinou added the bug label Oct 19, 2020
@KingDarBoja
Copy link
Author

I will take a look this week, the default should be indeed dark and just pass an option to disable it to avoid using use_dark_highlighting on every file.

@dom96
Copy link
Contributor

dom96 commented Oct 19, 2020

what does this look like? Screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Blog syntax highlight
4 participants